add refs variable for jtd validation#2316
Open
erikbrinkman wants to merge 1 commit intoajv-validator:masterfrom
Open
add refs variable for jtd validation#2316erikbrinkman wants to merge 1 commit intoajv-validator:masterfrom
erikbrinkman wants to merge 1 commit intoajv-validator:masterfrom
Conversation
80db1da to
4d001a5
Compare
There seems to be some weird behavior with typescript when refs was left to default. By specifying it manually the behavior was fixed. fixes ajv-validator#2167
0c0ae48 to
29168a4
Compare
Collaborator
Author
|
@epoberezkin something seems to have changed recently, and tests are failing silently at the build stage with: In general this seems like a version incompatibility between the local version of v8 and re2, but looking at successful builds, it looks like they were able to fetch the appropriate binary, so maybe the fix is getting that request to go through. The location seems to exist, so it must be some firewalling on githubs side. Otherwise, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be some weird behavior with typescript when refs was left to default. By specifying it manually the behavior was fixed.
What issue does this pull request resolve?
fixes #2167
What changes did you make?
R extends Record<string, unknown>to compile and validate for JTD schemas that resolves the referenced issue.--cacheto prettier invocation. This is not related to the diff, but a nice quality of life change. I'll remove if requestedIs there anything that requires more attention while reviewing?
--cacheto prettiercompileandvalidatehave really complicated types. This change only resolved the existing tests, but we know coverage is not 100%, so if anything comes to mind that this might hurt.with or without cache, prettier was tweaking files that broke typescript. I reverted the changes here to get the pull request in, but it's worth calling out