implement parallel schema loading#2575
Open
Kosta-Github wants to merge 1 commit intoajv-validator:masterfrom
Open
implement parallel schema loading#2575Kosta-Github wants to merge 1 commit intoajv-validator:masterfrom
Kosta-Github wants to merge 1 commit intoajv-validator:masterfrom
Conversation
* introduce a new flag `enableParallelLoading` * defaults to `false` to keep existing sequential behavior * when enabled the full schema gets scanned first for all external `$refs` and all missing `$refs` are loaded in parallel with `Promise.allSettled()` * this can speed up the loading process considerably for schemas that have a lot of external `$refs` * the existing and the new behavior are both covered by corresponding unit tests * documentation has been updated in various places as well
Author
|
The build is failing within the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
speed up the loading process of external
$refsif a schema contains a lot of themWhat changes did you make?
implement parallel schema loading
enableParallelLoadingfalseto keep existing sequential behavior$refsand all missing$refsare loaded in parallel withPromise.allSettled()$refsIs there anything that requires more attention while reviewing?
No