Fix throwing error when calling stop and pause functions#274
Open
powfix wants to merge 1 commit intoak1394:masterfrom
Open
Fix throwing error when calling stop and pause functions#274powfix wants to merge 1 commit intoak1394:masterfrom
powfix wants to merge 1 commit intoak1394:masterfrom
Conversation
Tts.stop() throwing an error. ak1394#273
fatidian1
reviewed
Dec 2, 2024
There was a problem hiding this comment.
@powfix I would do the same on line 181 - it also throws the same error for me.
mobile-vinsyt
approved these changes
Feb 5, 2025
|
yeah this method in TextToSpeech.mm has the same issue |
sumitk
approved these changes
Feb 13, 2025
|
The changes of this PR worked on
|
|
I can confirm the PR works fine, why it is in open? |
@HarshitMadhav This repo is dead... I switched to expo-audio, it doesn't have only switch tts engine feature, but rest works perfect and even web platform is supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change onWordBoundary argument type from (BOOL ) to (BOOL) in stop and pause functions
Issue: Tts.stop() throwing an error.
#273