Skip to content

fix: Remove continue-on-error #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Smartdevs17 wants to merge 5 commits into from
Closed

fix: Remove continue-on-error #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab80b0c
fix: Remove continue-on-error
Smartdevs17 Feb 5, 2026
a06ff0a
build: Remove `--exit-zero` from `flake8` and `pylint` commands to en…
Smartdevs17 Feb 9, 2026
065dfa5
build: Configure security checks (Safety, Bandit, pip-audit) to fail …
Smartdevs17 Feb 12, 2026
4f6fff3
test: introduce linting error to verify CI enforcement
Smartdevs17 Feb 16, 2026
f42e790
feat: remove test_ipc_upload_integration.py
Smartdevs17 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,30 +29,22 @@ jobs:
- name: Check code formatting with Black
run: |
black --check --diff akavesdk/ private/ sdk/ tests/
continue-on-error: true

- name: Check import sorting with isort
run: |
isort --check-only --diff akavesdk/ private/ sdk/ tests/
continue-on-error: true

- name: Lint with flake8
run: |
# Stop the build if there are Python syntax errors or undefined names
flake8 akavesdk/ private/ sdk/ tests/ --count --select=E9,F63,F7,F82 --show-source --statistics
# Exit-zero treats all errors as warnings
flake8 akavesdk/ private/ sdk/ tests/ --count --exit-zero --max-complexity=10 --max-line-length=120 --statistics
continue-on-error: true
flake8 akavesdk/ private/ sdk/ tests/ --count --max-complexity=10 --max-line-length=120 --show-source --statistics

- name: Lint with pylint
run: |
pylint akavesdk/ private/ sdk/ --max-line-length=120 --disable=C0111,R0903,W0212,C0103 --exit-zero
continue-on-error: true
pylint akavesdk/ private/ sdk/ --max-line-length=120 --disable=C0111,R0903,W0212,C0103

- name: Type check with mypy
run: |
mypy akavesdk/ private/ sdk/ --ignore-missing-imports --no-strict-optional
continue-on-error: true

security:
runs-on: ubuntu-latest
Expand All @@ -74,14 +66,12 @@ jobs:

- name: Check for security vulnerabilities with Safety
run: |
safety check --json || true
continue-on-error: true
safety check --json

- name: Security check with Bandit
run: |
bandit -r akavesdk/ private/ sdk/ -ll -f json -o bandit-report.json || true
bandit -r akavesdk/ private/ sdk/ -ll || true
continue-on-error: true
bandit -r akavesdk/ private/ sdk/ -ll -f json -o bandit-report.json
bandit -r akavesdk/ private/ sdk/ -ll

- name: Upload Bandit report
uses: actions/upload-artifact@v4
Expand All @@ -107,6 +97,5 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install pip-audit
pip-audit --desc || true
continue-on-error: true
pip-audit --desc

153 changes: 0 additions & 153 deletions test_ipc_upload_integration.py
View file
Open in desktop

This file was deleted.