Skip to content

Comments

Comprehensive Type Hint Improvements Across the SDK #36#37

Draft
manny-uncharted wants to merge 101 commits intoakave-ai:mainfrom
manny-uncharted:feat/36
Draft

Comprehensive Type Hint Improvements Across the SDK #36#37
manny-uncharted wants to merge 101 commits intoakave-ai:mainfrom
manny-uncharted:feat/36

Conversation

@manny-uncharted
Copy link
Contributor

@manny-uncharted manny-uncharted commented May 24, 2025

Closes out: #36

Implementation Plan:

Core SDK Class:

  • Add return types to all methods
  • Type all instance variables
  • Add docstrings with type information
  • Implement proper generic types

Model Classes:

  • Add type variables for generic containers
  • Implement protocols for common interfaces
  • Add return types to all methods
  • Type all instance variables

Utility Functions:

  • Add proper type hints to all utility functions
  • Use Union types where appropriate
  • Add Literal types for string constants

Configuration:

  • Add mypy configuration file
  • Set strict type checking options
  • Configure type checking in CI/CD

itsgurmannatsohal and others added 30 commits February 3, 2025 02:58
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
Signed-off-by: tejas-2512 <97736641+tejas-2512@users.noreply.github.com>
Signed-off-by: tejas-2512 <97736641+tejas-2512@users.noreply.github.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
added sdk with working tests
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Co-authored-by: Darshan Kumar <itsdarshankumar@gmail.com>
Co-authored-by: Gurmannat Sohal <iamgurmannatsohal@gmail.com>
manny-uncharted and others added 30 commits June 7, 2025 13:25
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
FIX: Code duplication in sdk/models.py and sdk/sdk_streaming.py
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Signed-off-by: Amit Pandey <amit08072005@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants