Add mixed return type for key and current methods#297
Open
DavidePastore wants to merge 1 commit intoakeneo:masterfrom
Open
Add mixed return type for key and current methods#297DavidePastore wants to merge 1 commit intoakeneo:masterfrom
DavidePastore wants to merge 1 commit intoakeneo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the warning that I see in the logs when using the client:
User Deprecated: Method "Iterator::key()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Akeneo\Pim\ApiClient\Pagination\ResourceCursor" now to avoid errors or add an explicit @return annotation to suppress this message. {"exception":"[object] (ErrorException(code: 0): User Deprecated: Method \"Iterator::key()\" might add \"mixed\" as a native return type declaration in the future. Do the same in implementation \"Akeneo\\Pim\\ApiClient\\Pagination\\ResourceCursor\" now to avoid errors or add an explicit @return annotation to suppress this message. at /var/www/app/vendor/symfony/error-handler/DebugClassLoader.php:341)"} {"containerName":""}This PR enforces the return types of
keyandcurrentmethods.