Add error state to login and register forms#235
Open
daryllxd wants to merge 2 commits intoalan2207:masterfrom
Open
Add error state to login and register forms#235daryllxd wants to merge 2 commits intoalan2207:masterfrom
daryllxd wants to merge 2 commits intoalan2207:masterfrom
Conversation
✅ Deploy Preview for bulletproof-react-app canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, was just trying the repo out and when I forgot to start the API server, there was no clear error message. IMO app should show a message to if the users weren't able to log in or register, especially for newbies in React trying to figure a good app structure to base off of
classNameprop to Error to not make the error message too cramped.Caveat