Skip to content

Exclude windows compilation from all target on non x86_64#345

Open
dcermak wants to merge 1 commit intoalexellis:masterfrom
dcermak:fix_aarch64_build
Open

Exclude windows compilation from all target on non x86_64#345
dcermak wants to merge 1 commit intoalexellis:masterfrom
dcermak:fix_aarch64_build

Conversation

@dcermak
Copy link

@dcermak dcermak commented Sep 23, 2021

Description

Exclude windows compilation from all target on non x86_64

Motivation and Context

golang does not support windows on non x86_64 architectures which makes make all fail on e.g. aarch64

How Has This Been Tested?

I have compiled k3sup on x86_64 and aarch64.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

alexellis
alexellis approved these changes Sep 23, 2021
View reviewed changes
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis
Copy link
Owner

alexellis commented Sep 23, 2021

Thanks for the contribution.

Can you tell me the story behind why you are building k3sup instead of using the binary?

@alexellis
Copy link
Owner

alexellis commented Sep 23, 2021

golang does not support windows on non x86_64 architectures which makes make all fail on e.g. aarch64

Does that include Apple M1? I was fairly sure I created x86 Windows binaries for other projects there, but I could be imagining it.

@dcermak
Copy link
Author

dcermak commented Sep 23, 2021

Thanks for the contribution.

Can you tell me the story behind why you are building k3sup instead of using the binary?

I am testing a multi-arch container for golang and am testing whether it can build popular golang applications.

golang does not support windows on non x86_64 architectures which makes make all fail on e.g. aarch64

Does that include Apple M1? I was fairly sure I created x86 Windows binaries for other projects there, but I could be imagining it.

I don't know to be frankly honest, as I don't own a Apple M1. I have run the build on a Cavium Thunder X2.

@dcermak
Copy link
Author

dcermak commented Oct 28, 2021

Friendly bump :)

@dcermak
Exclude windows compilation from all target on non x86_64
068c06d 
golang does not support windows on non x86_64 architectures which makes `make
all` fail on e.g. aarch64

Signed-off-by: Dan Čermák <dcermak@suse.com>
@dcermak
Copy link
Author

dcermak commented Sep 30, 2022

@alexellis Can we merge this?

@alexellis
Copy link
Owner

alexellis commented Oct 3, 2022 •
edited
Loading

Hi, I'm glad that you enjoy K3sup.

This is not something that I need at this time, but if you'd like to sponsor me on GitHub, then I'd merge it and maintain it.

Alex

@dcermak dcermak mentioned this pull request Mar 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexellis alexellis alexellis approved these changes

Assignees

No one assigned

Labels

new-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcermak @alexellis