Closed
Conversation
Collaborator
|
Problem is that we are just preparing a breaking release, i.e. there are already PRs included which changes the interface. |
Contributor
Author
|
Hm, in understand, that's unfortunate. Do you have a time horizon for this new version? |
Collaborator
|
Obsolete via #102. Seems like |
Contributor
Author
|
Great to hear! Thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ederc could you please release a patch release containing this so we can continue with making the new Nemo available in Oscar? Thanks
There should be no breaking changes that are relevant to AlgebraicSolving. But note that the hashing of
Vector{ZZRingElem}was slightly changed to be more in line withVector{Int}(at least in the case that all entries of the vector are bounded by 2^63), so this could cause issues if some test relies on the iteration order of elements of a set or dict (as e.g. doctests printing such sets or dicts do).