Skip to content

Close fig option#27

Merged
ali-ramadhan merged 3 commits intoali-ramadhan:mainfrom
denehoffman:close-fig-option
Aug 16, 2025
Merged

Close fig option#27
ali-ramadhan merged 3 commits intoali-ramadhan:mainfrom
denehoffman:close-fig-option

Conversation

@denehoffman
Copy link
Contributor

Adds an optional close_fig: bool = True argument to save_frame for the edge cases where one might want to keep the figure open between frames (could be used for blitting maybe, passing the figure in as an argument and just updating it rather than redrawing the whole thing).

Closes #8

Copy link
Owner

@ali-ramadhan ali-ramadhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the second contribution and for closing another open issue! Looks good to me. I think you accidentally included examples/lorenz.py in this PR but otherwise happy to merge!

@denehoffman
Copy link
Contributor Author

Whoops, I wasn't careful with my branches! And no problem, I just saw a few things that I could do quickly, I'm a big fan of the library!

@ali-ramadhan
Copy link
Owner

Looks good now and tests pass so I'll merge! Didn't think anyone was really using matplotloom except me haha, glad to hear you like it. Please feel free to suggest any improvements or open PRs!

@ali-ramadhan ali-ramadhan merged commit dd82902 into ali-ramadhan:main Aug 16, 2025
12 checks passed
@ali-ramadhan
Copy link
Owner

I'll also tag a new version (v0.9.1) so anyone who needs this option can use a tagged release.

@denehoffman
Copy link
Contributor Author

denehoffman commented Aug 16, 2025

Didn't think anyone was really using matplotloom except me haha, glad to hear you like it.

It is really convenient to set up and use matplotloom, I actually used it for an animation for my PhD thesis defense. Maybe not the cleanest work, but it gets the job done and everyone was impressed!

Please feel free to suggest any improvements or open PRs!

Will do!

@denehoffman denehoffman deleted the close-fig-option branch August 16, 2025 23:21
@ali-ramadhan
Copy link
Owner

That's a sweet animation and it's pretty cool how you got the zoom out effect! Glad to hear it was useful enough to make it into someone's thesis defense haha. Congratulations on defending by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option for save_frame to close the figure.

2 participants