Skip to content

keep the TTL in BLMOVE #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alicebob merged 1 commit into from
May 14, 2025
+14 −1
Merged

keep the TTL in BLMOVE #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmd_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,10 @@ func (m *Miniredis) cmdBlmove(c *server.Peer, cmd string, args []string) {
return true
}

var elem string
var (
elem string
ttl = db.ttl[opts.src] // in case we empty the array (deletes the entry)
)
switch opts.srcDir {
case "left":
elem = db.listLpop(opts.src)
Expand All @@ -1042,6 +1045,9 @@ func (m *Miniredis) cmdBlmove(c *server.Peer, cmd string, args []string) {
c.WriteError(msgSyntaxError)
return true
}
if ttl > 0 {
db.ttl[opts.dst] = ttl
}

c.WriteBulk(elem)
return true
Expand Down
7 changes: 7 additions & 0 deletions integration/list_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,13 @@ func TestBlmove(t *testing.T) {
c.Do("BLMOVE", "round", "round", "RIGHT", "RIGHT", "0")
c.Do("LRANGE", "round", "0", "-1")

// TTL
c.Do("LPUSH", "test", "1")
c.Do("EXPIRE", "test", "1000")
c.Do("TTL", "test")
c.Do("BLMOVE", "test", "test", "LEFT", "LEFT", "1")
c.Do("TTL", "test")

// failure cases
c.Do("RPUSH", "chk", "aap", "noot", "mies")
c.Error("wrong number", "LMOVE")
Expand Down