Skip to content

Simple support for DUMP and RESTORE #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alicebob merged 4 commits into from
Jun 14, 2025
+489 −350
Merged

Simple support for DUMP and RESTORE #405

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6ae403
constants for key types
alyssaruth May 15, 2025
360d575
shared logic for validating argument counts
alyssaruth May 17, 2025
24e0b1d
simple support for DUMP and RESTORE
alyssaruth May 17, 2025
fd1acee
revert DebugDump rename
alyssaruth Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Implemented commands:
- Key
- COPY
- DEL
- DUMP -- partly, only handles string keys
- EXISTS
- EXPIRE
- EXPIREAT
Expand All @@ -50,6 +51,7 @@ Implemented commands:
- RANDOMKEY -- see m.Seed(...)
- RENAME
- RENAMENX
- RESTORE -- partly, only handles string keys
- SCAN
- TOUCH
- TTL
Expand Down Expand Up @@ -301,10 +303,8 @@ Commands which will probably not be implemented:
- ~~READONLY~~
- ~~READWRITE~~
- Key
- ~~DUMP~~
- ~~MIGRATE~~
- ~~OBJECT~~
- ~~RESTORE~~
- ~~WAIT~~
- Scripting
- ~~FCALL / FCALL_RO *~~
Expand Down
7 changes: 1 addition & 6 deletions cmd_connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,7 @@ func (m *Miniredis) cmdEcho(c *server.Peer, cmd string, args []string) {

// SELECT
func (m *Miniredis) cmdSelect(c *server.Peer, cmd string, args []string) {
if len(args) != 1 {
setDirty(c)
c.WriteError(errWrongNumber(cmd))
return
}
if !m.isValidCMD(c, cmd) {
if !m.isValidCMD(c, cmd, args, exactly(1)) {
return
}

Expand Down
Loading
Loading