Skip to content

Fix track_env command execution in aliBuild init#968

Merged
ktf merged 1 commit intomasterfrom
getstatusoutput_init
Sep 25, 2025
Merged

Fix track_env command execution in aliBuild init#968
ktf merged 1 commit intomasterfrom
getstatusoutput_init

Conversation

@singiamtel
Copy link
Collaborator

The performPreferCheck function in init.py was hardcoded to always return
(1, "") which caused all track_env commands to fail during initialization.

Fixes error: "Error while executing track_env for O2PhysicsO2PHYSICS_COMPONENTS: echo
${O2PHYSICS_COMPONENTS:-install} =>"

Regression spotted in alisw/alidist#5888

CC @ktf @fjonasALICE

Current output from master:

❯ aliBuild init O2Physics@master
WARNING: using existing recipes from ./alidist
ERROR: Error while executing track_env for O2PhysicsO2PHYSICS_COMPONENTS: echo ${O2PHYSICS_COMPONENTS:-install} =>

from this PR:

❮ ./aliBuild init O2Physics@master
WARNING: using existing recipes from ./alidist

==> Development directory . created for o2physics

The performPreferCheck function in init.py was hardcoded to always return
(1, "") which caused all track_env commands to fail during initialization.

Fixes error: "Error while executing track_env for O2PhysicsO2PHYSICS_COMPONENTS: echo
${O2PHYSICS_COMPONENTS:-install} =>"

Regression spotted in alisw/alidist#5888
@ktf
Copy link
Member

ktf commented Sep 25, 2025

Thank you for looking into it.

Doesn't the behaviour change with this, making it impossible to do init of packages which come from the system? While In general it should not be an issue (it's unlikely we need to modify packages which can be picked up from the system), it would still be good if that's handled. Am I wrong?

@singiamtel
Copy link
Collaborator Author

Thank you for looking into it.

Doesn't the behaviour change with this, making it impossible to do init of packages which come from the system? While In general it should not be an issue (it's unlikely we need to modify packages which can be picked up from the system), it would still be good if that's handled. Am I wrong?

I can't reproduce this, I can init packages that aliDoctor picks up from the system, and packages that it tries and fails to do so too (I tested with sqlite and CMake on my mac)

@ktf ktf enabled auto-merge (rebase) September 25, 2025 17:10
@ktf ktf disabled auto-merge September 25, 2025 17:10
@ktf ktf enabled auto-merge (rebase) September 25, 2025 17:10
@ktf ktf disabled auto-merge September 25, 2025 17:48
@ktf ktf merged commit 0c63e03 into master Sep 25, 2025
10 checks passed
@ktf ktf deleted the getstatusoutput_init branch September 25, 2025 17:48
@ktf
Copy link
Member

ktf commented Sep 26, 2025

Ok, thanks. Can you do another release with this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants