Fix track_env command execution in aliBuild init#968
Conversation
The performPreferCheck function in init.py was hardcoded to always return
(1, "") which caused all track_env commands to fail during initialization.
Fixes error: "Error while executing track_env for O2PhysicsO2PHYSICS_COMPONENTS: echo
${O2PHYSICS_COMPONENTS:-install} =>"
Regression spotted in alisw/alidist#5888
|
Thank you for looking into it. Doesn't the behaviour change with this, making it impossible to do init of packages which come from the system? While In general it should not be an issue (it's unlikely we need to modify packages which can be picked up from the system), it would still be good if that's handled. Am I wrong? |
I can't reproduce this, I can init packages that aliDoctor picks up from the system, and packages that it tries and fails to do so too (I tested with sqlite and CMake on my mac) |
|
Ok, thanks. Can you do another release with this? Thanks. |
The performPreferCheck function in init.py was hardcoded to always return
(1, "") which caused all track_env commands to fail during initialization.
Fixes error: "Error while executing track_env for O2PhysicsO2PHYSICS_COMPONENTS: echo
${O2PHYSICS_COMPONENTS:-install} =>"
Regression spotted in alisw/alidist#5888
CC @ktf @fjonasALICE
Current output from master:
from this PR: