Skip to content

Conversation

@AlexanderTar
Copy link
Contributor

Adding Circle's Arc testnet chain

@zerosnacks
Copy link
Member

Hi @AlexanderTar , thanks for your PR

Make sure to follow all these steps:

chains/src/named.rs

Lines 7 to 20 in 51b1911

// When adding a new chain:
// 1. add new variant to the NamedChain enum;
// 2. add extra information in the last `impl` block (explorer URLs, block time) when applicable;
// 3. (optional) add aliases:
// - Strum (in kebab-case): `#[strum(to_string = "<main>", serialize = "<aliasX>", ...)]`
// `to_string = "<main>"` must be present and will be used in `Display`, `Serialize`
// and `FromStr`, while `serialize = "<aliasX>"` will be appended to `FromStr`.
// More info: <https://docs.rs/strum/latest/strum/additional_attributes/index.html#attributes-on-variants>
// - Serde (in snake_case): `#[cfg_attr(feature = "serde", serde(alias = "<aliasX>", ...))]`
// Aliases are appended to the `Deserialize` implementation.
// More info: <https://serde.rs/variant-attrs.html>
// - Add a test at the bottom of the file
// 4. run `cargo test --all-features` to update the JSON bindings and schema.
// 5. run `cargo +nightly fmt --all` to properly format the code.

@twi-alexandertar
Copy link
Contributor

Hey @zerosnacks - all done, sorry for not reading the instructions fully

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@mattsse mattsse merged commit 1f782ea into alloy-rs:main Jan 23, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants