Fix for #893 - param annotation name not coming up in report#1130
Open
mr-possible wants to merge 1 commit intoallure-framework:mainfrom
Open
Fix for #893 - param annotation name not coming up in report#1130mr-possible wants to merge 1 commit intoallure-framework:mainfrom
mr-possible wants to merge 1 commit intoallure-framework:mainfrom
Conversation
baev
requested changes
Sep 25, 2024
allure-testng/src/test/java/io/qameta/allure/testng/samples/ParameterizedTest.java
Outdated
Show resolved
Hide resolved
baev
requested changes
Sep 25, 2024
Member
baev
left a comment
baev
left a comment
There was a problem hiding this comment.
Please don't use wildcard imports. Otherwise — great job 👍
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java
Outdated
Show resolved
Hide resolved
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java
Outdated
Show resolved
Hide resolved
baev
approved these changes
Sep 26, 2024
mr-possible
force-pushed
the
main
branch
2 times, most recently
from
b4cd9ad to
603bd6f
Compare
Author
|
hey @baev , can we merge this? |
Author
|
Can we merge this ? @baev It's been sitting since quite long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #893
Context
Before fix:
After fix:
Checklist