Skip to content

Removed Microsoft.Extensions.DependencyInjection from generated usings.#35

Merged
temonk merged 3 commits intomainfrom
bugfix/extraDependency
Jan 12, 2026
Merged

Removed Microsoft.Extensions.DependencyInjection from generated usings.#35
temonk merged 3 commits intomainfrom
bugfix/extraDependency

Conversation

@temonk
Copy link
Contributor

@temonk temonk commented Jan 12, 2026

Updated MethodGeneratorHelper and regenerated test files to exclude the directive.

Temo Nikolaishvili added 2 commits January 12, 2026 14:00
Updated MethodGeneratorHelper and regenerated test files to exclude the directive.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused using Microsoft.Extensions.DependencyInjection; directive from the code generator's output. The generator creates OpenApiHelper classes that do not use any types from this namespace, making the using directive unnecessary.

Changes:

  • Removed the Microsoft.Extensions.DependencyInjection using directive from MethodGeneratorHelper.cs
  • Regenerated 27 test snapshot files to reflect the updated generator output
  • Bumped version from 7.0.0 to 7.0.1 in Directory.Build.props

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

File Description
src/AltaSoft.DomainPrimitives.Generator/Helpers/MethodGeneratorHelper.cs Removed unused Microsoft.Extensions.DependencyInjection from the usings collection in AddOpenApiSchemas method
Directory.Build.props Updated version to 7.0.1 and removed empty line between PropertyGroup elements
tests/.../Snapshots/*#OpenApiHelper.g.verified.cs (27 files) Regenerated snapshot files reflecting the removal of the unused using directive

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty line was removed between the two PropertyGroup elements. This whitespace change appears unrelated to the stated purpose of this PR (removing Microsoft.Extensions.DependencyInjection from generated usings). Consider whether this whitespace change was intentional, and if not, restore the empty line for consistency with the existing file formatting.

Suggested change

Copilot uses AI. Check for mistakes.
@temonk temonk merged commit baf1b44 into main Jan 12, 2026
1 check passed
@temonk temonk deleted the bugfix/extraDependency branch January 12, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant