Fix: support datetime + pandas.Timedelta addition in AddNumericScalar#2769
Open
Hasan-8326 wants to merge 1 commit intoalteryx:mainfrom
Open
Fix: support datetime + pandas.Timedelta addition in AddNumericScalar#2769Hasan-8326 wants to merge 1 commit intoalteryx:mainfrom
Hasan-8326 wants to merge 1 commit intoalteryx:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where adding a pandas.Timedelta to a datetime feature (e.g., f + pd.Timedelta(1, 'y')) raised an AssertionError in Featuretools. The root cause was that the AddNumericScalar primitive only supported numeric addition and did not handle datetime + timedelta operations. This update enhances AddNumericScalar to support both numeric and datetime inputs, allowing datetime features to be correctly offset by pandas.Timedelta values. The change maintains backward compatibility with numeric features and ensures that time-based arithmetic works as expected in feature definitions.