Support aie4 get async error ioctl and async shim tests#1042
Support aie4 get async error ioctl and async shim tests#1042
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for AIE4 asynchronous error handling through a new ioctl and corresponding test infrastructure. It extends the existing async error framework to handle AIE4-specific context errors reported by the firmware.
Changes:
- Implements
aie4_error_get_last_async()to retrieve cached async errors via ioctl - Adds AIE4 context error parsing with detailed health report logging
- Introduces
TEST_async_error_aie4_iotest case usingbad_ctrl.elfto trigger and verify context errors
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/driver/amdxdna/aie4_error.c | Adds context error caching logic and retrieval function for AIE4 async errors |
| src/driver/amdxdna/aie4_pci.c | Implements ioctl handler for DRM_AMDXDNA_HW_LAST_ASYNC_ERR parameter |
| src/driver/amdxdna/aie4_pci.h | Declares aie4_error_get_last_async() function prototype |
| test/shim_test/io.cpp | Implements AIE4 async error test class with error verification |
| test/shim_test/io.h | Declares async_error_aie4_io_test_bo_set class |
| test/shim_test/io_test.cpp | Adds test entry point for AIE4 async error testing |
| test/shim_test/shim_test.cpp | Registers new test case and updates device filters |
| test/shim_test/dev_info.cpp | Adds bad_ctrl.elf xclbin metadata for NPU3 devices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
129a9e3 to
22e83e4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>
a066afb to
7572422
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>
Tested on silicon