Skip to content

Support aie4 get async error ioctl and async shim tests#1042

Merged
maxzhen merged 2 commits intoamd:mainfrom
hlaccabu:async
Feb 6, 2026
Merged

Support aie4 get async error ioctl and async shim tests#1042
maxzhen merged 2 commits intoamd:mainfrom
hlaccabu:async

Conversation

@hlaccabu
Copy link
Contributor

Tested on silicon

@hlaccabu hlaccabu requested review from Copilot and xdavidz January 30, 2026 20:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for AIE4 asynchronous error handling through a new ioctl and corresponding test infrastructure. It extends the existing async error framework to handle AIE4-specific context errors reported by the firmware.

Changes:

  • Implements aie4_error_get_last_async() to retrieve cached async errors via ioctl
  • Adds AIE4 context error parsing with detailed health report logging
  • Introduces TEST_async_error_aie4_io test case using bad_ctrl.elf to trigger and verify context errors

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/driver/amdxdna/aie4_error.c Adds context error caching logic and retrieval function for AIE4 async errors
src/driver/amdxdna/aie4_pci.c Implements ioctl handler for DRM_AMDXDNA_HW_LAST_ASYNC_ERR parameter
src/driver/amdxdna/aie4_pci.h Declares aie4_error_get_last_async() function prototype
test/shim_test/io.cpp Implements AIE4 async error test class with error verification
test/shim_test/io.h Declares async_error_aie4_io_test_bo_set class
test/shim_test/io_test.cpp Adds test entry point for AIE4 async error testing
test/shim_test/shim_test.cpp Registers new test case and updates device filters
test/shim_test/dev_info.cpp Adds bad_ctrl.elf xclbin metadata for NPU3 devices

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hlaccabu hlaccabu force-pushed the async branch 2 times, most recently from 129a9e3 to 22e83e4 Compare January 30, 2026 22:57
Copilot AI review requested due to automatic review settings January 30, 2026 22:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

xdavidz
xdavidz previously approved these changes Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>
@hlaccabu hlaccabu force-pushed the async branch 2 times, most recently from a066afb to 7572422 Compare February 6, 2026 20:07
Copilot AI review requested due to automatic review settings February 6, 2026 20:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amd amd deleted a comment from Copilot AI Feb 6, 2026
@amd amd deleted a comment from Copilot AI Feb 6, 2026
@amd amd deleted a comment from Copilot AI Feb 6, 2026
Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>
@maxzhen maxzhen merged commit eb3aeda into amd:main Feb 6, 2026
1 check passed
@hlaccabu hlaccabu deleted the async branch February 6, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants