Skip to content

Enhance and clean up xrt_test and shim_test interfaces#1049

Merged
maxzhen merged 1 commit intoamd:mainfrom
hlaccabu:xrt_test
Feb 6, 2026
Merged

Enhance and clean up xrt_test and shim_test interfaces#1049
maxzhen merged 1 commit intoamd:mainfrom
hlaccabu:xrt_test

Conversation

@hlaccabu
Copy link
Contributor

@hlaccabu hlaccabu commented Feb 4, 2026

No description provided.

@hlaccabu hlaccabu requested a review from xdavidz February 4, 2026 00:04
Copilot AI review requested due to automatic review settings February 4, 2026 00:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances and cleans up the xrt_test and shim_test interfaces by restructuring test data paths, removing deprecated functionality, and improving test execution patterns. The changes streamline the testing framework by consolidating path handling, removing unused parameters, and enhancing help output.

Changes:

  • Reorganized test data paths to use architecture-specific and test-specific subdirectories
  • Removed deprecated -s and -d command-line options and related functionality
  • Refactored stress test implementations to use consistent execution patterns with timing metrics
  • Enhanced help messages to include available test cases listing

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test/xrt_test/xrt_test.cpp Restructured test data paths, removed deprecated options, refactored stress tests, moved runlist test, and enhanced help output
test/shim_test/shim_test.cpp Added test listing to help output
test/shim_test/dev_info.cpp Updated workspace paths to new directory structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hlaccabu hlaccabu force-pushed the xrt_test branch 2 times, most recently from d1aabc8 to b764baf Compare February 4, 2026 00:08
Copilot AI review requested due to automatic review settings February 4, 2026 00:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hlaccabu hlaccabu force-pushed the xrt_test branch 2 times, most recently from 1c5c2de to 59d41de Compare February 4, 2026 04:18
Copilot AI review requested due to automatic review settings February 4, 2026 04:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hlaccabu hlaccabu force-pushed the xrt_test branch 2 times, most recently from 4e147d0 to 96ab106 Compare February 4, 2026 05:00
Copilot AI review requested due to automatic review settings February 4, 2026 05:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>
Copilot AI review requested due to automatic review settings February 5, 2026 21:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amd amd deleted a comment from Copilot AI Feb 6, 2026
@maxzhen maxzhen merged commit 9bedc97 into amd:main Feb 6, 2026
1 check passed
@hlaccabu hlaccabu deleted the xrt_test branch February 6, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants