Conversation
Checks object part is Iterable not (tuple, list, set)
|
thanks for contributing @guility . can you add a test that shows how not having this causes problems? |
|
Hello @guility! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-10-22 16:49:27 UTC |
|
@amirziai basically, if applying only to .jsons - there would be no such a problem. You could check the test case in my latest commit to test your code with custom iterable. |
|
That's a great test! Thanks! Do you mind fixing the PEP8 issue too? See the comment from @pep8speaks ☝️ |
|
also your branch is behind master, please merge the latest. |
Checks object part is Iterable not (tuple, list, set)
Allows to use deal with numpy.arrays and subclasses inside the dictionaries.