Support for joins partially done#127
Open
orlleite wants to merge 4 commits intoamitshekhariitbhu:masterfrom
Open
Support for joins partially done#127orlleite wants to merge 4 commits intoamitshekhariitbhu:masterfrom
orlleite wants to merge 4 commits intoamitshekhariitbhu:masterfrom
Conversation
Owner
|
@orlleite Please explain why you declared it as a partial? Also, it would be great if you make a PR against the development branch. |
| import android.content.ContentValues; | ||
| import android.database.Cursor; | ||
| import android.database.SQLException; | ||
| import android.util.Log; |
Contributor
There was a problem hiding this comment.
Only an (unused) import statement was added in this file. It would be good to remove it again before the merge ;)
Author
|
I'm sorry, I don't remember precisely. I thought there are two ways of running queries. I'm assuming that, because I saw some "IFs" in the code. I changed it enough to make it works for me. I said 'partially' because I'm not confident to say 'completely'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTableNametogetTableNamesto returnString[];getTableDatareceivesString[] tableNamesand could handle those situations in future;getTableDataif got more than one tableName, it will not replace query string values so it will be able to show the result but not editing values.