TOP - Restringir volver a auditoria si la solicitud tiene turno asignado#3254
Open
Fabio-Ramirez wants to merge 1 commit intomasterfrom
Open
TOP - Restringir volver a auditoria si la solicitud tiene turno asignado#3254Fabio-Ramirez wants to merge 1 commit intomasterfrom
Fabio-Ramirez wants to merge 1 commit intomasterfrom
Conversation
Fabio-Ramirez
force-pushed
the
TOP-199
branch
from
934933b to
3459b13
Compare
AgosLizzi
approved these changes
Oct 30, 2025
Fabio-Ramirez
force-pushed
the
TOP-199
branch
from
3459b13 to
15406ee
Compare
Fabio-Ramirez
force-pushed
the
TOP-199
branch
from
15406ee to
16be5c8
Compare
Contributor
Todo ok funcionado. Saludos
|
nicolasarana
approved these changes
Nov 27, 2025
MarianoCampetella
requested changes
Dec 1, 2025
| import { Component, ElementRef, HostBinding, Input, OnInit, ViewChild } from '@angular/core'; | ||
| import { Router } from '@angular/router'; | ||
| import { catchError, concatWith, map, switchMap } from 'rxjs'; | ||
| import { catchError, concatWith, map, switchMap, EMPTY, from, filter, NEVER } from 'rxjs'; |
Contributor
There was a problem hiding this comment.
La variable empty no se está utilizando.
El resto anda perfecto.
Contributor
Author
There was a problem hiding this comment.
Gracias compa, queda subido el cambio.
MarianoCampetella
added
changes requested
Fabio-Ramirez
force-pushed
the
TOP-199
branch
from
16be5c8 to
784eedc
Compare
Fabio-Ramirez
added
changes done
and removed
changes requested
negro89
reviewed
Dec 2, 2025
| this.servicioPrestacion.getById(this.prestacionSeleccionada._id) | ||
| .pipe( | ||
| switchMap(prestacion => { | ||
| const tieneTurnoInvalido = |
Contributor
There was a problem hiding this comment.
Me hace ruido el nombre, el turno se dió correctamente. Lo dejaría como "tieneTurno"
negro89
reviewed
Dec 2, 2025
Contributor
negro89
left a comment
negro89
left a comment
There was a problem hiding this comment.
No se si hubo un cambio de rumbo en la tarea a ultimo momento pero pedía que el control estuviera del lado de la api. A pesar de esto me parece que está bien resuelto y la solución es válida.
Funciona de 10 pero dejo la duda para consultar mañana 👌🏼
Fabio-Ramirez
force-pushed
the
TOP-199
branch
from
784eedc to
3c4bd8a
Compare
Contributor
|
aprobado por chayanne 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/TOP-199
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion