fixed issue with __buildTree arguments#4
Open
ShubhamShaswat wants to merge 1 commit intoandipro123:masterfrom
Open
fixed issue with __buildTree arguments#4ShubhamShaswat wants to merge 1 commit intoandipro123:masterfrom
ShubhamShaswat wants to merge 1 commit intoandipro123:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is regarding Issue #1
It seems like the makeTreeFromArray() method is not being called correctly. The issue is that when calling the private function __buildTree() inside makeTreeFromArray(), it's missing the required positional arguments.
It throws this Error:
Solution:
To fix this, you need to pass the necessary arguments when calling __buildTree() inside makeTreeFromArray(). Specifically, you need to pass self.root as the root node, and 0 and the length of the array as i and n respectively.