Conversation
Owner
|
Looks good, but the tests are failing. I think at this point we might need to migrate to Jest test runner and use its snapshot testing functionality so updating snapshots can be done automatically. |
Author
|
Migrating to Jest test runner is a different PR IMO. Would you like to do it now? Or I can update the tests to make them pass. |
Owner
|
You can just update the tests.
…On Thu, 16 Mar 2017 at 15:07 Aymeric Bouzy ***@***.***> wrote:
Migrating to Jest test runner is a different PR IMO. Would you like to do
it now? Or I can update the tests to make them pass.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB3glSoXrElPAxRxwlzf7KBgVn4iAnfks5rmSYZgaJpZM4MfG_x>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before I write tests for it, is this the way you envisioned it?