Skip to content

Explicitly disable parallel Gradle build#1165

Closed
emrekultursay wants to merge 1 commit intoandroid:mainfrom
emrekultursay:no_more_parallel_build
Closed

Explicitly disable parallel Gradle build#1165
emrekultursay wants to merge 1 commit intoandroid:mainfrom
emrekultursay:no_more_parallel_build

Conversation

@emrekultursay
Copy link
Contributor

@emrekultursay emrekultursay commented Jan 29, 2026

When building the entire project with Gradle, if Gradle-level inter-project parallelism is enabled (either via the property org.gradle.parallel=true, or via Android Studio injected flags), then the build was failing, because these sub-projects under the teapots project all try to write their ndkHelper library outputs to the same path, causing a race condition.

@gemini-code-assist
Copy link

Summary of Changes

Hello @emrekultursay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves build instability in the ndk-samples project by preventing parallel execution of Gradle tasks. The project's architecture, which includes multiple Gradle modules with interdependent CMake/C++ sub-builds sharing a common native library, was leading to race conditions during parallel builds. By explicitly disabling this feature, the change ensures a more reliable and sequential build process, eliminating the source of these build failures.

Highlights

  • Gradle Parallel Build Disabled: Explicitly disables parallel Gradle builds by setting org.gradle.parallel=false in gradle.properties.
  • Race Condition Resolution: This change addresses race conditions that occur at the CMake/C++ level when multiple Gradle modules, each with its own C++ sub-build, attempt to build in parallel while sharing a common native library.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly disables parallel Gradle builds to prevent race conditions in the native sub-builds, as described. The change is a direct and effective fix for the issue. I've added one suggestion to include a comment in gradle.properties to document the reason for this configuration, which will improve long-term maintainability for other developers working on this project.

@emrekultursay emrekultursay force-pushed the no_more_parallel_build branch from 0d052a8 to 2887c74 Compare January 29, 2026 19:11
When building the entire project with Gradle, if Gradle-level
inter-project parallelism is enabled (either via the property
org.gradle.parallel=true, or via Android Studio injected flags),
then the build was failing, because these sub-projects under
the teapots project all try to write their ndkHelper library
outputs to the same path, causing a race condition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant