This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Open
Conversation
SigmanZero
reviewed
Aug 10, 2023
Contributor
SigmanZero
left a comment
SigmanZero
left a comment
There was a problem hiding this comment.
Sorry for the delay! I've requested some fixes.
common/src/main/java/com/example/android/uamp/media/MusicService.kt
Outdated
Show resolved
Hide resolved
common/src/main/java/com/example/android/uamp/media/MusicService.kt
Outdated
Show resolved
Hide resolved
common/src/main/java/com/example/android/uamp/media/MusicService.kt
Outdated
Show resolved
Hide resolved
common/src/main/java/com/example/android/uamp/media/MusicService.kt
Outdated
Show resolved
Hide resolved
SigmanZero
changed the title
SigmanZero
reviewed
Aug 15, 2023
Contributor
SigmanZero
left a comment
SigmanZero
left a comment
There was a problem hiding this comment.
Thank you! Looking much better - I think you're adding the commands in correctly now. Just one last comment about the functionality of each command.
| } | ||
|
|
||
| if (customCommand.customAction == SEEK_BACK) { | ||
| exoPlayer.seekBack() |
Contributor
There was a problem hiding this comment.
These commands are replicating functionality that's already handled by standard commands defined by a Player, which we don't want to encourage (see the note at the end of this section) - could you update these commands to do something different? Here are some ideas:
- Jump to a random item in the current playlist (see one of my previous comments for some pointers on how to execute on this)
- Copy the current song title to the clipboard (https://developer.android.com/develop/ui/views/touch-and-input/copy-paste#Copying)
- Add the current song to some sort of "favorites" list (You could do similar logic to what we have here, but with
FAVORITE_SONG_*_KEY)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to enhance the compatibility and functionality of the uamp application by enabling the transmission of custom actions from the main app to connected client apps.