This repository was archived by the owner on Oct 2, 2019. It is now read-only.
chore(tests): use headless browser for tests#2108
Open
neolitec wants to merge 2 commits intoangular-ui:masterfrom
neolitec:tests-puppeteer
Open
chore(tests): use headless browser for tests#2108neolitec wants to merge 2 commits intoangular-ui:masterfrom neolitec:tests-puppeteer
neolitec wants to merge 2 commits intoangular-ui:masterfrom
neolitec:tests-puppeteer
Conversation
Author
|
Tests don't pass because Node is too old for Puppeteer... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've made a very small update on the test to use a headless browser instead of a real one that pop in my face every time I run tests.
I would like to share it, so... voilà.
:)