fix: Correct the image_version conditional#2082
Merged
lucas-benedito merged 2 commits intoansible:develfrom Oct 9, 2025
Merged
fix: Correct the image_version conditional#2082lucas-benedito merged 2 commits intoansible:develfrom
lucas-benedito merged 2 commits intoansible:develfrom
Conversation
lucas-benedito
force-pushed
the
fix_img_version_conditional
branch
from
decda98 to
292da21
Compare
When image is set and image_version is unset, the conditional is failing due to the unset variable causes and error. Implemented the correct conditional and added an assert to validate that both variables are set properly when image is set. Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
lucas-benedito
force-pushed
the
fix_img_version_conditional
branch
from
292da21 to
a1191f7
Compare
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
lucas-benedito
force-pushed
the
fix_img_version_conditional
branch
from
1273af4 to
61da164
Compare
dsavineau
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
When image is set and image_version is unset, the conditional fails due to the unset variable causing an error.
Implemented the correct conditional and added an assert to validate that both variables are set properly when image is set.
ISSUE TYPE