Skip to content

TEST: Maxwell example check test#499

Open
anur7 wants to merge 7 commits intomainfrom
test/ut_examples_1
Open

TEST: Maxwell example check test#499
anur7 wants to merge 7 commits intomainfrom
test/ut_examples_1

Conversation

@anur7
Copy link
Collaborator

@anur7 anur7 commented Jan 16, 2026

Description

Add test to check Maxwell resistance.py example.

Issue linked

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

@anur7 anur7 self-assigned this Jan 16, 2026
@anur7 anur7 linked an issue Jan 16, 2026 that may be closed by this pull request
nunesanderson
nunesanderson previously approved these changes Jan 16, 2026
Copy link
Collaborator

@nunesanderson nunesanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Collaborator

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anur7 @nunesanderson Implemented as it is, it's going to fail.
You are importing a method that is in the pyaedt-examples repo and the user does not install the package in the venv that is using to run the example. In the venv there will be only pyaedt (ideally).
I think this method should not be part of the examples repo but rather in pyaedt.

@Samuelopez-ansys @SMoraisAnsys

@Samuelopez-ansys
Copy link
Member

@gmalinve is right.

This could be a new file in PyAEDT, if it is something we do not expect users to use it could be implemented here:

https://github.com/ansys/pyaedt/tree/main/src/ansys/aedt/core/internal

or if it is something useful to be exposed:

https://github.com/ansys/pyaedt/tree/main/src/ansys/aedt/core/generic

@gmalinve
Copy link
Collaborator

@Samuelopez-ansys I guess we can reuse this one from PyAEDT: https://github.com/ansys/pyaedt/blob/d7025d55af2978fa5a66504eda6fd3bdaf2a0309/src/ansys/aedt/core/generic/numbers_utils.py#L400 as @eblanco-ansys pointed out.

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft January 21, 2026 08:00
@anur7 anur7 marked this pull request as ready for review January 27, 2026 10:20
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modifications @anur7, I left some comments

@anur7 anur7 requested a review from SMoraisAnsys January 27, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maxwell example check test

6 participants