Conversation
gmalinve
left a comment
There was a problem hiding this comment.
@anur7 @nunesanderson Implemented as it is, it's going to fail.
You are importing a method that is in the pyaedt-examples repo and the user does not install the package in the venv that is using to run the example. In the venv there will be only pyaedt (ideally).
I think this method should not be part of the examples repo but rather in pyaedt.
|
@gmalinve is right. This could be a new file in PyAEDT, if it is something we do not expect users to use it could be implemented here: https://github.com/ansys/pyaedt/tree/main/src/ansys/aedt/core/internal or if it is something useful to be exposed: https://github.com/ansys/pyaedt/tree/main/src/ansys/aedt/core/generic |
|
@Samuelopez-ansys I guess we can reuse this one from PyAEDT: https://github.com/ansys/pyaedt/blob/d7025d55af2978fa5a66504eda6fd3bdaf2a0309/src/ansys/aedt/core/generic/numbers_utils.py#L400 as @eblanco-ansys pointed out. |
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Thanks for the modifications @anur7, I left some comments
…453) Co-authored-by: Abdun Nur <146203416+anur7@users.noreply.github.com>
Description
Add test to check Maxwell resistance.py example.
Issue linked
Checklist
Please complete the following checklist before submitting your pull request: