-
Notifications
You must be signed in to change notification settings - Fork 220
FIX: local access to file in example-data repo #7212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Devin-Crawford
wants to merge
16
commits into
main
Choose a base branch
from
fix/local_example_download
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix #7202 (incorrect handling of file) - Remove incorrectly handled debug statements. - Add unit test when using local repo to test example data.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7212 +/- ##
===========================================
- Coverage 83.47% 21.14% -62.33%
===========================================
Files 254 253 -1
Lines 76596 76517 -79
===========================================
- Hits 63938 16180 -47758
- Misses 12658 60337 +47679 🚀 New features to boost your workflow:
|
cleans up its own directory after teardown, preventing race conditions when pytest-xdist workers tear down module-scoped file_tmp_root while function-scoped fixtures still need the directory.
3c4c529 to
dd53d4e
Compare
- Add while loop in test_analyze.py test_3dl_analyze_setup()
… fix/local_example_download # Conflicts: # tests/system/solvers/test_analyze.py
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
# Conflicts: # tests/conftest.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
#7202
Checklist