-
Notifications
You must be signed in to change notification settings - Fork 81
fix(dist): remove liburing-devel from pre-cxx11 distribution image #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: #1565 Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Summary of ChangesHello @wxyucs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a specific issue by modifying the build process for the pre-C++11 distribution Docker image. It removes an unnecessary development dependency, aiming to streamline the image and resolve potential build or compatibility problems, as indicated by the linked issue. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the liburing-devel dependency from the pre-cxx11 distribution image, which is appropriate for the manylinux2014 base image that does not support io_uring. I have added one suggestion to further optimize the Docker image by cleaning the package manager cache after installation, which is a common best practice for creating smaller images.
|
|
||
| # install deps | ||
| RUN yum update && yum install -y gcc-gfortran python3-devel libaio-devel liburing-devel | ||
| RUN yum update && yum install -y gcc-gfortran python3-devel libaio-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reduce the Docker image size, it's a good practice to clean the yum cache within the same RUN layer after installing packages. This prevents the cache from being stored in the layer, making the final image smaller. Consider applying this optimization to other Dockerfiles in the repository as well.
RUN yum update && yum install -y gcc-gfortran python3-devel libaio-devel && yum clean all
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1567 +/- ##
==========================================
- Coverage 91.11% 90.96% -0.15%
==========================================
Files 329 329
Lines 19396 19396
==========================================
- Hits 17673 17644 -29
- Misses 1723 1752 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
already done in #1566 |
fix: #1565