Merged
Conversation
JPVenson
force-pushed
the
save/vertex_1
branch
from
2bd5321 to
8164794
Compare
sd-st
reviewed
Feb 4, 2026
Collaborator
sd-st
left a comment
sd-st
left a comment
There was a problem hiding this comment.
Nice! Just had a few minor comments
JPVenson
force-pushed
the
save/vertex_1
branch
from
7b4b65e to
8d3dacf
Compare
Collaborator
|
LGTM! Needs a rebase (which may require some small code changes; they updated their spec) |
Collaborator
|
Also how did you test this locally with an access token/project ID/region? |
Contributor
Author
|
ahrrrrg i JUST rebased it like 30 minutes ago! i am currently writing an doc on steps to get the nessesary google stuff setup but i can send you the test stuff on slack. The vertex example holds everything nessesary for it in its comment |
Collaborator
|
Yeah sorry they just did a release so there were some changes 😅 |
Add vertex example Add explicit body check for vertex Readd explicit check for model value in bedrock client lint reintroduce null forgiving operator as required by build
JPVenson
force-pushed
the
save/vertex_1
branch
from
2a0cf26 to
51bb210
Compare
Collaborator
|
Tested locally. A few things to address:
|
Contributor
Author
|
sd-st
reviewed
Feb 6, 2026
sd-st
reviewed
Feb 6, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds googles
vertexplatform as supported providerAdds Examples as own project (as discussed in the #77 pr)
Adds inclusion into tests.
Note: As vertex the same as bedrock does not follow the same api structure as anthropic does, testing with the internal test server isn't possible as of now. The code has been manually tested for compliance for all supported endpoints