This repository was archived by the owner on Feb 25, 2019. It is now read-only.
Add support for Webpack's NodeJS targets#84
Open
ryan-codingintrigue wants to merge 2 commits intoanvilresearch:masterfrom
Open
Add support for Webpack's NodeJS targets#84ryan-codingintrigue wants to merge 2 commits intoanvilresearch:masterfrom
ryan-codingintrigue wants to merge 2 commits intoanvilresearch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know the README says Not for use in Webpack, but Webpack isn't only used for outputting browser code. When using a target other than
web(NodeJS, Electron, etc.) there's no reason this library shouldn't be able to be bundled using Webpack too.The reason it doesn't work is because of this block of code:
webcrypto/src/algorithms/SupportedAlgorithms.js
Line 84 in 5303c62
Webpack doesn't handle dynamic
requirevery well.This PR addresses the issue by turning the
registeredAlgorithmsinto a factory function, rather than a path, allowing Webpack to effectively track which files should be bundled. This will allow users to use Webpack for any NodeJS target