Directly call $this->getOutput()->write() to avoid an extra newline in the tail command#32
Open
squatto wants to merge 2 commits intoanystack-sh:mainfrom
Open
Conversation
Contributor
Author
|
@PhiloNL there's one more simple change left if/when you have a quick sec to merge it as well 🙏🏻 🙏🏻 Thanks!! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a formatting issue in the tail command where extra newlines were being added between output lines. The problem occurred because fgets() reads lines with their trailing newline characters, but the existing code was using $this->line() which adds an additional newline via writeln().
- Changed from
$this->line($line)to$this->getOutput()->write($line)to preserve original line formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
tailcommand calls$this->line($line), which in turn calls$this->getOutput()->writeln($line). Since the log file is being read withfgets(),$lineincludes the ending newline character. Passing this towriteln()appends another newline character, resulting in an empty/blank line between each output line:This change simply directly calls
$this->getOutput()->write($line)to avoid appending an extra newline character:This resolves #12