-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Refactor HttpAsyncHook to support session-based async HTTP operations and simplify LivyAsyncHook #60458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dabla
wants to merge
38
commits into
apache:main
Choose a base branch
from
dabla:feature/add-session-async-http-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+314
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f9c503d.
…tmanager in HttpAsyncHook
…m HttpAsyncHook so it doesn't rely on the error handling of the HttpAsyncHook run method
…tched on http hook module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
This PR refactors
HttpAsyncHookto natively support session-based async HTTP usage, making it easier and safer to perform multiple HTTP requests within a singleaiohttp.ClientSession.As part of this refactor,
LivyAsyncHook(which extendsHttpAsyncHook) is simplified to reuse shared logic, removing duplicated code and avoiding internal state mutation during request execution.Before this change, users who wanted to reuse an
aiohttp.ClientSessionhad to manage the session lifecycle themselves and pass it intoHttpAsyncHook.run(). This resulted in boilerplate-heavy task code and made it harder to apply hook-level configuration consistently.Instead of having to do this:
You will be able to do this instead as the
HttpAsyncHooknow exposes a session-based API that encapsulates session creation, configuration, authentication, and retry logic:This approach:
aiohttp.ClientSessionmanagement in tasks (no more boilerplate code needed).LivyAsyncHook improvements
LivyAsyncHooknow reuses the session and request logic provided byHttpAsyncHooksession context manager._do_api_call_asynchas been removed.self.method) when callingrun_method.Overall behaviour is unchanged, but the implementation is more DRY, predictable, and maintainable
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.