fix(test): refactor test_reopen_log_fd to use context manager for log fd handling #61415
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugraoz93
reviewed
Feb 3, 2026
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
I think we should test this in all versions while seeing that it failed on Python 3.13 in the CI
bugraoz93
added
the
all versions
Contributor
|
When you updated fixing p10, please close and reopen for running test for all versions |
Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
henry3260
force-pushed
the
fix-test-reading-from-pipes
branch
from
b10977d to
ed520b2
Compare
Contributor
Author
|
The CI failure seems unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor test_reopen_log_fd to use a context manager for log fd handling
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.