[fix] Ledger Replication worker should throttle on verrification reads#4678
Open
vraulji567 wants to merge 1 commit intoapache:branch-4.17from
Open
[fix] Ledger Replication worker should throttle on verrification reads#4678vraulji567 wants to merge 1 commit intoapache:branch-4.17from
vraulji567 wants to merge 1 commit intoapache:branch-4.17from
Conversation
Author
|
@rdhabalia Can you help review this pull request? |
Author
|
@ivankelly @merlimat Can someone help to review the pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Replication worker fails to replicate ledgers with thousands of entries when
auditorLedgerVerificationPercentageis set to 100. The verification process makes too many read requests at once exceedingmaxPendingReadRequestsPerThreadand fails withToo many requests to the same Bookie while reading. The verification process should not make too many simultaneous reads and throttle the reads based oninFlightReadEntryNumInLedgerChecker.Changes
Pass the config to the verification process(LedgerChecker) while initializing it as part of the Replication worker to throttle the number of simultaneous reads to the bookie preventing
Too many requests to the same Bookie while readingerror and replication of large ledgers with 100% verification possible.Added a test to verify the throttling logic.