chore: modernize List usage and minor style fixes#8268
Open
sanjana2505006 wants to merge 1 commit intoapache:mainfrom
Open
chore: modernize List usage and minor style fixes#8268sanjana2505006 wants to merge 1 commit intoapache:mainfrom
sanjana2505006 wants to merge 1 commit intoapache:mainfrom
Conversation
sanjana2505006
force-pushed
the
chore/modernize-code-style
branch
from
2cc3f6b to
67c6bc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking through the codebase and noticed a few places where we could use
List.ofinstead ofArrays.asListfor better consistency and conciseness.I also spotted a double semicolon in a test file and some unused imports, so I cleaned those up while I was at it.