Open
Conversation
The variable `segNumber` in foreign.c was defined but never used, which is not necessary.
avamingli
reviewed
Oct 9, 2025
Comment on lines
-422
to
-424
| int segNumber; | ||
|
|
||
| segNumber = GetForeignTableSegNumbers(relid); |
Contributor
There was a problem hiding this comment.
The codes are introduced by CBDB at commit ed64982,
It looks like the intent to update ForeignTable.num_segments was missed or forgotten in this block, specifically around line 440. Instead of deleting the logic, we should ensure ForeignTable.num_segments is assigned the correct value there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable
segNumberin foreign.c was defined but never used, which is not necessary.Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions