Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi, @jangjangji welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
Author
Thanks for reviewing! |
- Add buffer.seek(0) after truncate to reset file pointer position - Add isinstance and len check before accessing item[16] to prevent IndexError - Improves robustness when processing malformed CSV log entries
my-ship-it
force-pushed
the
fix-logfilter-csv-buffer
branch
from
5d9ea28 to
81e2de2
Compare
gfphoenix78
reviewed
Nov 26, 2025
Comment on lines
+282
to
+283
| if isinstance(item, list) and len(item) > 16: | ||
| item[16] = item[16] + ": " |
Contributor
There was a problem hiding this comment.
When is the condition false? Is it correct to ignore the else branch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
This PR fixes two issues in the
CsvFlattenclass ingplogfilter:buffer.seek(0)aftertruncate(0)to properly reset the StringIO file pointer position.item[16]to preventIndexErroron malformed CSV rows.Type of Change
Test Plan
gplogfiltercorrectly filters CSV logs with time range and pattern matchingmake installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
No measurable impact expected.
User-facing changes:
None (internal logic improvement only).
Dependencies:
No changes.
Checklist
Additional Context
N/A
CI Skip Instructions