Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
===========================================
+ Coverage 17.53% 50.05% +32.51%
===========================================
Files 4 4
Lines 975 975
===========================================
+ Hits 171 488 +317
+ Misses 800 473 -327
- Partials 4 14 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the CloudStack Kubernetes Provider for the v1.2.0 release by updating the deployment image version and significantly enhancing documentation for LoadBalancer service annotations and node labeling behavior.
Key changes:
- Updated container image from v1.1.0 to v1.2.0 in deployment configuration
- Added comprehensive documentation for three LoadBalancer service annotations with detailed descriptions, use cases, and examples
- Clarified the node region label assignment logic to specify it uses config region when defined, otherwise falls back to zone
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deployment.yaml | Updates cloud-controller-manager container image version from v1.1.0 to v1.2.0 |
| README.md | Adds "Service Annotations" section documenting cloudstack-load-balancer-proxy-protocol, cloudstack-load-balancer-hostname, and cloudstack-load-balancer-source-cidrs annotations; clarifies region label assignment logic for both legacy and modern Kubernetes label formats |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DaanHoogland
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates documentation and deployment configuration for the CloudStack Kubernetes Provider. The main focus is on enhancing the
README.mdwith detailed explanations of supported service annotations for LoadBalancer services, clarifying node label assignment logic, and updating the deployment image version.Documentation improvements:
Added a new "Service Annotations" section to
README.mddescribing three supported annotations for LoadBalancer services:cloudstack-load-balancer-proxy-protocol(for enabling HAProxy Proxy Protocol),cloudstack-load-balancer-hostname(for setting a hostname as ingress),cloudstack-load-balancer-source-cidrs(for restricting allowed source CIDRs).Each annotation includes type, default, use case, and example usage.
Clarified the logic for node region labels in
README.md, specifying that the region label uses the region from config if defined, otherwise defaults to the zone.Deployment update:
deployment.yamlfrom versionv1.1.0tov1.2.0for thecloud-controller-manager.