Skip to content

Fix injection of preset variables into the JS interpreter #12515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 4 commits into from
Feb 11, 2026
+122 −1,136
Merged

Fix injection of preset variables into the JS interpreter #12515

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0ffad2
Fix injection of preset variables into the JS interpreter
winterhazel Jan 25, 2026
6c819d0
Fix HeuristicRuleHelper tests
winterhazel Jan 25, 2026
d2ca3ef
Address copilot review
winterhazel Jan 27, 2026
f920c7f
Merge remote-tracking branch 'upstream/4.20' into fix-preset-variable…
winterhazel Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge remote-tracking branch 'upstream/4.20' into fix-preset-variable… 
…-injection
  • Loading branch information
@winterhazel
winterhazel committed Jan 28, 2026
commit f920c7f19e937204ccd8d54f5fe7af8cb5024cd5
6 changes: 3 additions & 3 deletions server/src/main/java/org/apache/cloudstack/storage/heuristics/HeuristicRuleHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,9 @@ protected Template setTemplatePresetVariable(VMTemplateVO templateVO) {
protected Volume setVolumePresetVariable(com.cloud.storage.Volume volumeVO) {
Volume volumePresetVariable = new Volume();

volume.setName(volumeVO.getName());
volume.setFormat(volumeVO.getFormat().toString());
volume.setSize(volumeVO.getSize());
volumePresetVariable.setName(volumeVO.getName());
volumePresetVariable.setFormat(volumeVO.getFormat().toString());
volumePresetVariable.setSize(volumeVO.getSize());

return volumePresetVariable;
}
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.