-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[UI] Allow change password for native users only. #12584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
@DaanHoogland moving to draft based on your comment here - #12581 (comment) |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12584 +/- ##
=============================================
- Coverage 16.26% 4.16% -12.11%
=============================================
Files 5660 403 -5257
Lines 499963 32919 -467044
Branches 60708 5886 -54822
=============================================
- Hits 81330 1370 -79960
+ Misses 409559 31373 -378186
+ Partials 9074 176 -8898
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, but I have questions about the functionality. As this fixes a bug atm (NPE when tried) I think we can go ahead. Users/operators will have to define how a broken or removed link of an authenticator should be handled. E.G. invalidate/regenerate PW or disable account. I could imagine this should be configurable in which case we can revert this condition.
We can also remove the need to be a native account now, and fix the NPE.
< @sureshanaparti >
updated @DaanHoogland it also checks for admin, domain admin account or the same user to change the password. |
Description
This PR allows change password for native users only from UI.
Fixes #12581
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested with the users form with native, ldap, saml users.
How did you try to break this feature and the system with this change?