Skip to content

Conversation

@sureshanaparti
Copy link
Contributor

Description

This PR allows change password for native users only from UI.

Fixes #12581

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested with the users form with native, ldap, saml users.

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@sureshanaparti
Copy link
Contributor Author

@DaanHoogland moving to draft based on your comment here - #12581 (comment)

@sureshanaparti sureshanaparti marked this pull request as draft February 4, 2026 13:15
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.16%. Comparing base (9ae696d) to head (76d1cb5).

❗ There is a different number of reports uploaded between BASE (9ae696d) and HEAD (76d1cb5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9ae696d) HEAD (76d1cb5)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.20   #12584       +/-   ##
=============================================
- Coverage     16.26%    4.16%   -12.11%     
=============================================
  Files          5660      403     -5257     
  Lines        499963    32919   -467044     
  Branches      60708     5886    -54822     
=============================================
- Hits          81330     1370    -79960     
+ Misses       409559    31373   -378186     
+ Partials       9074      176     -8898     
Flag Coverage Δ
uitests 4.16% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12584 (QA-JID-871)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, but I have questions about the functionality. As this fixes a bug atm (NPE when tried) I think we can go ahead. Users/operators will have to define how a broken or removed link of an authenticator should be handled. E.G. invalidate/regenerate PW or disable account. I could imagine this should be configurable in which case we can revert this condition.

We can also remove the need to be a native account now, and fix the NPE.

< @sureshanaparti >

@sureshanaparti
Copy link
Contributor Author

clgtm, but I have questions about the functionality. As this fixes a bug atm (NPE when tried) I think we can go ahead. Users/operators will have to define how a broken or removed link of an authenticator should be handled. E.G. invalidate/regenerate PW or disable account. I could imagine this should be configurable in which case we can revert this condition.

We can also remove the need to be a native account now, and fix the NPE.

< @sureshanaparti >

updated @DaanHoogland it also checks for admin, domain admin account or the same user to change the password.

@sureshanaparti sureshanaparti marked this pull request as ready for review February 4, 2026 15:01
@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change password should be not allowed for LDAP and SAML based account

3 participants