Open
Conversation
garydgregory
requested changes
Feb 3, 2026
Member
garydgregory
left a comment
There was a problem hiding this comment.
Hello @fadedblack
Thank you for your PR!
Please add a unit test for the test vectors in https://datatracker.ietf.org/doc/html/draft-msporny-base58-03 (see the end of the document).
garydgregory
requested changes
Feb 3, 2026
Member
garydgregory
left a comment
There was a problem hiding this comment.
This PR doesn't even compile...
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.1:compile (default-compile) on project commons-codec: Compilation failure: Compilation failure:
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58InputStream.java:[57,41] cannot find symbol
Error: symbol: class AbstracBuilder
Error: location: class org.apache.commons.codec.binary.Base58InputStream
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58OutputStream.java:[61,41] cannot find symbol
Error: symbol: class AbstractBuilder
Error: location: class org.apache.commons.codec.binary.Base58OutputStream
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58InputStream.java:[50,106] type argument org.apache.commons.codec.binary.Base58InputStream.Builder is not within bounds of type-variable B
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58InputStream.java:[66,9] method does not override or implement a method from a supertype
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58InputStream.java:[71,9] method does not override or implement a method from a supertype
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58InputStream.java:[88,15] incompatible types: org.apache.commons.codec.binary.Base58InputStream.Builder cannot be converted to org.apache.commons.codec.binary.BaseNCodecInputStream.AbstracBuilder<org.apache.commons.codec.binary.Base58InputStream,org.apache.commons.codec.binary.Base58,org.apache.commons.codec.binary.Base58InputStream.Builder>
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58InputStream.java:[97,24] cannot find symbol
Error: symbol: method setInputStream(java.io.InputStream)
Error: location: class org.apache.commons.codec.binary.Base58InputStream.Builder
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58InputStream.java:[109,24] cannot find symbol
Error: symbol: method setInputStream(java.io.InputStream)
Error: location: class org.apache.commons.codec.binary.Base58InputStream.Builder
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58OutputStream.java:[54,110] type argument org.apache.commons.codec.binary.Base58OutputStream.Builder is not within bounds of type-variable B
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58OutputStream.java:[67,13] cannot find symbol
Error: symbol: method setEncode(boolean)
Error: location: class org.apache.commons.codec.binary.Base58OutputStream.Builder
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58OutputStream.java:[75,9] method does not override or implement a method from a supertype
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58OutputStream.java:[85,9] method does not override or implement a method from a supertype
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58OutputStream.java:[102,15] incompatible types: org.apache.commons.codec.binary.Base58OutputStream.Builder cannot be converted to org.apache.commons.codec.binary.BaseNCodecOutputStream.AbstractBuilder<org.apache.commons.codec.binary.Base58OutputStream,org.apache.commons.codec.binary.Base58,org.apache.commons.codec.binary.Base58OutputStream.Builder>
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58OutputStream.java:[111,23] cannot find symbol
Error: symbol: method setOutputStream(java.io.OutputStream)
Error: location: class org.apache.commons.codec.binary.Base58OutputStream.Builder
Error: /home/runner/work/commons-codec/commons-codec/src/main/java/org/apache/commons/codec/binary/Base58OutputStream.java:[123,24] cannot find symbol
Error: symbol: method setOutputStream(java.io.OutputStream)
Error: location: class org.apache.commons.codec.binary.Base58OutputStream.Builder
Error: -> [Help 1]
Author
|
Hey @garydgregory mb, I had my build configurations wrong. Will fix and re-push. EDIT1: Also, this is my mvn configurations EDIT2: |
ecki
reviewed
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an new implementation of Base58 as mentioned in the https://issues.apache.org/jira/browse/CODEC-326.
It creates 3 new classes.
The Base58 encoder takes in a byte array and converts it into Base10 number which is then in-turn converted into Base58. The implementation of how to convert to Base58 is given here https://learnmeabitcoin.com/technical/keys/base58/
Github Copilot was used to generate unit tests and write java docs for the classes