[IO-842] deprecate writeLines methods without a charset#563
Open
elharo wants to merge 2 commits intoapache:masterfrom
Open
[IO-842] deprecate writeLines methods without a charset#563elharo wants to merge 2 commits intoapache:masterfrom
elharo wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #563 +/- ##
=========================================
Coverage 85.99% 85.99%
Complexity 3498 3498
=========================================
Files 231 231
Lines 8256 8256
Branches 965 965
=========================================
Hits 7100 7100
Misses 865 865
Partials 291 291 ☔ View full report in Codecov by Sentry. |
Member
Member
|
Let's wait to see what happens with https://issues.apache.org/jira/browse/IO-842 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also corrects Javadoc about which exception is thrown when the charset is not recognized and adds test for same. Note that the exception thrown is not changed here. I brought the documentation into sync with the actual pre-existing behavior. @garydgregory