VFS-824 HttpFileSystem free Unused Resources lead to HttpClient Conn…#300
VFS-824 HttpFileSystem free Unused Resources lead to HttpClient Conn…#300mind-echo wants to merge 15 commits intoapache:masterfrom
Conversation
…ction Pool Shutdown
…onnection Pool Shutdown Option One：While Unused Resources, close HttpFileSystem
…onnection Pool Shutdown Option Two：Share ConnectionManager.
|
How about the http5 file provider? |
|
Hello @destroydestiny |
Http, http4, http5 provider has the same problem |
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileProvider.java
Show resolved
Hide resolved
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileProvider.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileProvider.java
Outdated
Show resolved
Hide resolved
|
You must have not run a local build with the default Maven goal ( |
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileProvider.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileProvider.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileProvider.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/http/HttpProviderTestCase.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/http5/Http5ProviderTestCase.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/http5/Http5ProviderTestCase.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/http4/Http4ProviderTestCase.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/http/HttpProviderTestCase.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/http/HttpProviderTestCase.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/http4/Http4ProviderTestCase.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/http5/Http5ProviderTestCase.java
Outdated
Show resolved
Hide resolved
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
Hello @destroydestiny
Thank you for your updates. Please see my comments.
…Client Connection Pool Shutdown" This reverts commit 7c09877.
Hi @garydgregory |
|
It's possible one of these changes is breaking the build randomly. |
…eSystem.isReleaseable is true
…eSystem.isReleaseable is true
|
I need to look at this more closely over the weekend: I don't know why the HTTP providers have to be unique and different compared to all the others. Is the use of concepts in this PR backward? In the PR, the "free" code now also "closes" resources and that feels backward to me. I expect the "close" code to also "free" resources are part of closing, not the other way around. |
I think this problem needs to be considered from the beginning. The root cause is that "free" code closes httpClient. |
2 participants
…ection Pool Shutdown