fix: Ensure columns are casted to the correct names with Unions #20146
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
nuno-faria
commented
Feb 4, 2026
| Projection: test.col_int32 AS id | ||
| TableScan: test projection=[col_int32] | ||
| Projection: CAST(CAST(nodes.id AS Int64) + Int64(1) AS Int32) AS id | ||
| Projection: CAST(CAST(nodes.id AS Int64) + Int64(1) AS Int32) |
Contributor
Author
There was a problem hiding this comment.
These changes are ok, the alias had been introduced by #19019 but it was not needed.
Contributor
There was a problem hiding this comment.
it isn't needed because the outer query doesn't use id?
alamb
approved these changes
Feb 4, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @nuno-faria -- this looks good to me. Given all the tests pass I think this one is good to go, though it is strange to me 🤔 I wonder if this is something specific to unions
| Ok(expr.cast_to(new_type, src_schema)?.alias(name)) | ||
| match expr { | ||
| // maintain the original name when casting a column | ||
| Expr::Column(ref column) => { |
Contributor
There was a problem hiding this comment.
can we add some context about why we maintain the original name only for columns?
| Projection: test.col_int32 AS id | ||
| TableScan: test projection=[col_int32] | ||
| Projection: CAST(CAST(nodes.id AS Int64) + Int64(1) AS Int32) AS id | ||
| Projection: CAST(CAST(nodes.id AS Int64) + Int64(1) AS Int32) |
Contributor
There was a problem hiding this comment.
it isn't needed because the outer query doesn't use id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When aliasing a cast, use the original name to prevent duplicate column names errors.
What changes are included in this PR?
coerce_exprs_for_schemato use the correct name.Are these changes tested?
Yes.
Are there any user-facing changes?
No.