fix: Make serialize_to_file test cross platform
#20147
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Makes sense. Obviously we can't get an exhaustive list of error messages for all platforms. I guess we just need to add more cases here if someone shows up with a platform that doesn't match any of these... Could you leave a comment on each case explaining what platforms it covers?
Contributor
Author
Added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Make the
serialize_to_filesubstrait test work on different platforms.What changes are included in this PR?
serialize_to_file.Are these changes tested?
Yes.
Are there any user-facing changes?
No.