fix: datatype_is_logically_equal for dictionaries#20153
Open
dd-annarose wants to merge 1 commit intoapache:mainfrom
Open
fix: datatype_is_logically_equal for dictionaries#20153dd-annarose wants to merge 1 commit intoapache:mainfrom
dd-annarose wants to merge 1 commit intoapache:mainfrom
Conversation
notfilippo
approved these changes
Feb 4, 2026
Member
notfilippo
left a comment
notfilippo
left a comment
There was a problem hiding this comment.
Makes sense to me! Thanks :)
gabotechs
approved these changes
Feb 4, 2026
Contributor
gabotechs
left a comment
gabotechs
left a comment
There was a problem hiding this comment.
Looks good! thanks @dd-annarose
dd-annarose
force-pushed
the
annarose/dict-coercion
branch
from
df92e66 to
321b285
Compare
dd-annarose
force-pushed
the
annarose/dict-coercion
branch
from
1a0c600 to
09c29d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
When checking logical equivalence with
Dictionary<_, Utf8>andUtf8View, the response wasfalsewhich is not what we expect (logical equivalence should be a transitive property).What changes are included in this PR?
This PR introduces a test and a fix. The test fails without the fix. The fix is simply calling
datatype_is_logically_equalagain on thev1andothertypewhen called withDictionary<K1, V1>andothertype.Are these changes tested?
Yes.
Are there any user-facing changes?
No.