Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions be/src/olap/row_cursor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -214,27 +214,6 @@ Status RowCursor::init_scan_key(TabletSchemaSPtr schema, const std::vector<std::
return _init_scan_key(schema, scan_keys);
}

Status RowCursor::build_max_key() {
for (auto cid : _schema->column_ids()) {
const Field* field = column_schema(cid);
char* dest = cell_ptr(cid);
field->set_to_max(dest);
set_not_null(cid);
}
return Status::OK();
}

Status RowCursor::build_min_key() {
for (auto cid : _schema->column_ids()) {
const Field* field = column_schema(cid);
char* dest = cell_ptr(cid);
field->set_to_min(dest);
set_null(cid);
}

return Status::OK();
}

Status RowCursor::from_tuple(const OlapTuple& tuple) {
if (tuple.size() != _schema->num_column_ids()) {
return Status::Error<INVALID_ARGUMENT>(
Expand Down
4 changes: 0 additions & 4 deletions be/src/olap/row_cursor.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@ class RowCursor {
return *reinterpret_cast<const char*>(cell(sign_idx).cell_ptr()) > 0;
}

// set max/min for key field in _field_array
Status build_max_key();
Status build_min_key();

char* get_buf() const { return _fixed_buf; }

// this two functions is used in unit test
Expand Down
2 changes: 1 addition & 1 deletion be/src/runtime_filter/runtime_filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class RuntimeFilter {
std::shared_ptr<RuntimeFilterWrapper> _wrapper;

// will apply to remote node
bool _has_remote_target = false;
const bool _has_remote_target;

// runtime filter type
RuntimeFilterType _runtime_filter_type = RuntimeFilterType::UNKNOWN_FILTER;
Expand Down
Loading